feat: add pattern and path to regexp create errors #2477 #2485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alidator/ajv into feat-add-informative-regexp-errors
jasoniangreen
commented
Aug 8, 2024
| const u = it.opts.unicodeRegExp ? "u" : "" | ||
| const regExp = $data ? _`(new RegExp(${schemaCode}, ${u}))` : usePattern(cxt, schema) |
There was a problem hiding this comment.
This was never using opts.code.regExp? Is that intentional?
jasoniangreen
commented
Aug 11, 2024
| throw new Error(e.message + ' | pattern ' + ${schemaCode} + ' at ' + ${it.errSchemaPath}) | ||
| } | ||
| })()` | ||
| : usePattern(cxt, schema) |
There was a problem hiding this comment.
There is probably a way to build this with gen.try etc but maybe this is ok? I'm still getting my head around codegen stuff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this pull request resolve?
#2477 - Wrap regexp instantiation in try/catch to add pattern and schema path to the error message
What changes did you make?
Wrapped both the regular and codegen'd versions of the pattern keyword regexp creation
Is there anything that requires more attention while reviewing?
Not sure if there is a better way to do the codegen, I did try using gen.try etc but couldn't figure it out.